Claude review: drm/msm/hdmi & phy: use generic PHY framework

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/msm/hdmi & phy: use generic PHY framework
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 5
Reviewed: 2026-03-16T12:07:57.782976

---

This is a v5 series by Dmitry Baryshkov that moves MSM HDMI PHY drivers from the DRM/MSM subsystem (`drivers/gpu/drm/msm/hdmi/`) to the generic PHY framework (`drivers/phy/qualcomm/`). The series is well-structured: patch 1 does the heavy lifting of the migration, patches 2-3 extract shared UNI PLL register definitions into a common header, and patch 4 adds MSM8974 HDMI PHY/PLL support that was previously missing.

**Strengths:**
- Clean architectural improvement: using the generic PHY framework instead of ad-hoc PHY APIs is the right approach
- Good code organization: pre-QMP PHYs (8x60, 8960, 8974) share a common `preqmp` driver, while QMP PHYs (8996, 8998) share a `qmp-hdmi` base
- The PLL rate calculation code for MSM8960/MSM8974 replaces fixed tables with computed values, extending mode support
- Net deletion of ~585 lines despite adding new functionality (MSM8974 PLL)
- Has existing reviews/acks (Neil Armstrong, Konrad Dybcio)

**Concerns:**
- The series ordering in the mbox is 0/4, 2/4, 3/4, 4/4, 1/4 — patch 1 arrives last, which is just a mbox ordering issue but worth noting
- A few minor code issues noted below
- Missing `qcom,hdmi-phy-8084` compatible in the new preqmp driver

---

---
Generated by Claude Code Patch Reviewer