From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: Drop the HPD state machine Date: Mon, 16 Mar 2026 12:12:55 +1000 Message-ID: In-Reply-To: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/dp: Drop the HPD state machine Author: Dmitry Baryshkov Patches: 13 Reviewed: 2026-03-16T12:12:55.366957 --- This v5 series removes the HPD state machine from the MSM DP driver, which = has been a long-standing source of bugs due to state mismatch between the D= RM framework and the DP driver's internal state. The approach is sound: rep= lace the custom event queue/thread with threaded IRQs and `drm_bridge_hpd_n= otify()`, unifying the internal HPD and external (USB-C) HPD paths. The ser= ies is well-structured with incremental cleanups leading to the big rework = in patch 7. However, there are several issues worth addressing =E2=80=94 mostly around = concurrency/locking in the reworked code, a logic error in `msm_dp_bridge_g= et_modes()`, and some concerns about pm_runtime reference balancing. --- Generated by Claude Code Patch Reviewer