From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd: fix HDMI output with non-HDMI EDID overrides Date: Mon, 16 Mar 2026 11:48:51 +1000 Message-ID: In-Reply-To: <20260315223307.45807-1-johanneswueller@gmail.com> References: <20260315223307.45807-1-johanneswueller@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amd: fix HDMI output with non-HDMI EDID overrides Author: =?UTF-8?q?Johannes=20W=C3=BCller?= Patches: 5 Reviewed: 2026-03-16T11:48:51.389884 --- This is a well-motivated 4-patch series that fixes a real usability problem: HDMI output fails when a non-HDMI EDID (e.g. DisplayPort EDID) is injected via `drm.edid_firmware` or debugfs `edid_override`. The series is well-structured, with clear commit messages and a logical progression. However, there are several design and correctness concerns, particularly around Patch 1's approach and Patch 2's interaction with `populate_hdmi_info_from_connector()`. --- Generated by Claude Code Patch Reviewer