public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/ttm: Fix spelling mistakes and comment style in ttm_resource.c
@ 2026-03-16  3:59 Varun Gupta
  2026-03-16  5:07 ` Claude review: " Claude Code Review Bot
  2026-03-16  5:07 ` Claude Code Review Bot
  0 siblings, 2 replies; 3+ messages in thread
From: Varun Gupta @ 2026-03-16  3:59 UTC (permalink / raw)
  To: dri-devel; +Cc: intel-xe, christian.koenig, matthew.auld, sanjay.kumar.yadav

Correct several spelling mistakes and textual inconsistencies in
kdoc comments and inline comments.

Suggested-by: Sanjay Yadav <sanjay.kumar.yadav@intel.com>
Signed-off-by: Varun Gupta <varun.gupta@intel.com>
---
 drivers/gpu/drm/ttm/ttm_resource.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
index 192fca24f37e..9f36631d48b6 100644
--- a/drivers/gpu/drm/ttm/ttm_resource.c
+++ b/drivers/gpu/drm/ttm/ttm_resource.c
@@ -37,7 +37,7 @@
 #include <drm/drm_print.h>
 #include <drm/drm_util.h>
 
-/* Detach the cursor from the bulk move list*/
+/* Detach the cursor from the bulk move list */
 static void
 ttm_resource_cursor_clear_bulk(struct ttm_resource_cursor *cursor)
 {
@@ -105,9 +105,9 @@ void ttm_resource_cursor_init(struct ttm_resource_cursor *cursor,
  * ttm_resource_cursor_fini() - Finalize the LRU list cursor usage
  * @cursor: The struct ttm_resource_cursor to finalize.
  *
- * The function pulls the LRU list cursor off any lists it was previusly
+ * The function pulls the LRU list cursor off any lists it was previously
  * attached to. Needs to be called with the LRU lock held. The function
- * can be called multiple times after eachother.
+ * can be called multiple times after each other.
  */
 void ttm_resource_cursor_fini(struct ttm_resource_cursor *cursor)
 {
@@ -317,10 +317,10 @@ void ttm_resource_move_to_lru_tail(struct ttm_resource *res)
 }
 
 /**
- * ttm_resource_init - resource object constructure
- * @bo: buffer object this resources is allocated for
+ * ttm_resource_init - resource object constructor
+ * @bo: buffer object this resource is allocated for
  * @place: placement of the resource
- * @res: the resource object to inistilize
+ * @res: the resource object to initialize
  *
  * Initialize a new resource object. Counterpart of ttm_resource_fini().
  */
@@ -435,7 +435,7 @@ EXPORT_SYMBOL(ttm_resource_free);
  * @size: How many bytes the new allocation needs.
  *
  * Test if @res intersects with @place and @size. Used for testing if evictions
- * are valueable or not.
+ * are valuable or not.
  *
  * Returns true if the res placement intersects with @place and @size.
  */
@@ -513,7 +513,7 @@ void ttm_resource_set_bo(struct ttm_resource *res,
  * @bdev: ttm device this manager belongs to
  * @size: size of managed resources in arbitrary units
  *
- * Initialise core parts of a manager object.
+ * Initialize core parts of a manager object.
  */
 void ttm_resource_manager_init(struct ttm_resource_manager *man,
 			       struct ttm_device *bdev,
@@ -536,8 +536,8 @@ EXPORT_SYMBOL(ttm_resource_manager_init);
 /*
  * ttm_resource_manager_evict_all
  *
- * @bdev - device to use
- * @man - manager to use
+ * @bdev: device to use
+ * @man: manager to use
  *
  * Evict all the objects out of a memory manager until it is empty.
  * Part of memory manager cleanup sequence.
@@ -882,7 +882,7 @@ ttm_kmap_iter_linear_io_init(struct ttm_kmap_iter_linear_io *iter_io,
 
 /**
  * ttm_kmap_iter_linear_io_fini - Clean up an iterator for linear io memory
- * @iter_io: The iterator to initialize
+ * @iter_io: The iterator to finalize
  * @bdev: The TTM device
  * @mem: The ttm resource representing the iomap.
  *
@@ -921,15 +921,15 @@ DEFINE_SHOW_ATTRIBUTE(ttm_resource_manager);
 /**
  * ttm_resource_manager_create_debugfs - Create debugfs entry for specified
  * resource manager.
- * @man: The TTM resource manager for which the debugfs stats file be creates
+ * @man: The TTM resource manager for which the debugfs stats file to be created
  * @parent: debugfs directory in which the file will reside
  * @name: The filename to create.
  *
- * This function setups up a debugfs file that can be used to look
+ * This function sets up a debugfs file that can be used to look
  * at debug statistics of the specified ttm_resource_manager.
  */
 void ttm_resource_manager_create_debugfs(struct ttm_resource_manager *man,
-					 struct dentry * parent,
+					 struct dentry *parent,
 					 const char *name)
 {
 #if defined(CONFIG_DEBUG_FS)
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Claude review: drm/ttm: Fix spelling mistakes and comment style in ttm_resource.c
  2026-03-16  3:59 [PATCH] drm/ttm: Fix spelling mistakes and comment style in ttm_resource.c Varun Gupta
@ 2026-03-16  5:07 ` Claude Code Review Bot
  2026-03-16  5:07 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-16  5:07 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm/ttm: Fix spelling mistakes and comment style in ttm_resource.c
Author: Varun Gupta <varun.gupta@intel.com>
Patches: 1
Reviewed: 2026-03-16T15:07:17.276066

---

This is a single cleanup patch that fixes spelling mistakes, comment inconsistencies, and a minor whitespace issue in `drivers/gpu/drm/ttm/ttm_resource.c`. All changes are documentation/comment-only with one whitespace fix in a function signature — no functional code changes. The fixes are correct and improve readability. This is straightforward and low-risk.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Claude review: drm/ttm: Fix spelling mistakes and comment style in ttm_resource.c
  2026-03-16  3:59 [PATCH] drm/ttm: Fix spelling mistakes and comment style in ttm_resource.c Varun Gupta
  2026-03-16  5:07 ` Claude review: " Claude Code Review Bot
@ 2026-03-16  5:07 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-16  5:07 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Overall:** All corrections are accurate. No issues found.

**Spelling fixes (all correct):**
- `previusly` → `previously`
- `eachother` → `each other`
- `constructure` → `constructor`
- `resources` → `resource` (grammar fix)
- `inistilize` → `initialize`
- `valueable` → `valuable`
- `Initialise` → `Initialize` (US English consistency)

**Comment style fixes (correct):**
- `/* Detach the cursor from the bulk move list*/` → `/* ... list */` — adds missing space before `*/`
- `@bdev - device to use` / `@man - manager to use` → uses `:` instead of `-` — correct kdoc syntax uses `@param:` not `@param -`

**Semantic fix (correct):**
- `@iter_io: The iterator to initialize` → `to finalize` in `ttm_kmap_iter_linear_io_fini` — the function is `_fini`, so "finalize" is the right word
- `@man: ... debugfs stats file be creates` → `file to be created` — grammar fix

**Comment improvement:**
- `This function setups up` → `This function sets up` — correct verb conjugation

**Whitespace fix:**
- `struct dentry * parent` → `struct dentry *parent` — aligns with kernel coding style (pointer `*` goes with the variable name)

**Nit:** The commit message says "kdoc comments" but lowercase; the conventional kernel spelling is "kerneldoc" or "kernel-doc." This is extremely minor and not worth respinning for.

**Verdict:** Patch looks good. All changes are correct and improve code quality. 

Reviewed-by worthy.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-16  5:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-16  3:59 [PATCH] drm/ttm: Fix spelling mistakes and comment style in ttm_resource.c Varun Gupta
2026-03-16  5:07 ` Claude review: " Claude Code Review Bot
2026-03-16  5:07 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox