From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: cgroup/dmem: return error when failing to set dmem.max
Date: Sun, 22 Mar 2026 05:01:51 +1000 [thread overview]
Message-ID: <review-overall-20260318-dmem_max_ebusy-v1-1-b7e461157b29@igalia.com> (raw)
In-Reply-To: <20260318-dmem_max_ebusy-v1-1-b7e461157b29@igalia.com>
Overall Series Review
Subject: cgroup/dmem: return error when failing to set dmem.max
Author: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Patches: 4
Reviewed: 2026-03-22T05:01:51.798365
---
This is a single-patch fix for the `cgroup/dmem` subsystem. The bug is clear and well-described: `page_counter_set_max()` can return `-EBUSY` when the current usage exceeds the requested new max, but the return value was being silently discarded by `set_resource_max()` (which returned `void`). The fix is straightforward and correct in approach — propagate the error from `page_counter_set_max()` back to userspace.
The patch is small, well-scoped, and the commit message includes a nice before/after demonstration. Overall this is a good bugfix.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 19:34 [PATCH] cgroup/dmem: return error when failing to set dmem.max Thadeu Lima de Souza Cascardo
2026-03-18 22:56 ` Tejun Heo
2026-03-19 7:33 ` Maarten Lankhorst
2026-03-19 9:40 ` Michal Koutný
2026-03-21 19:01 ` Claude Code Review Bot [this message]
2026-03-21 19:01 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260318-dmem_max_ebusy-v1-1-b7e461157b29@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox