From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: cgroup/dmem: return error when failing to set dmem.max Date: Sun, 22 Mar 2026 05:01:51 +1000 Message-ID: In-Reply-To: <20260318-dmem_max_ebusy-v1-1-b7e461157b29@igalia.com> References: <20260318-dmem_max_ebusy-v1-1-b7e461157b29@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: cgroup/dmem: return error when failing to set dmem.max Author: Thadeu Lima de Souza Cascardo Patches: 4 Reviewed: 2026-03-22T05:01:51.798365 --- This is a single-patch fix for the `cgroup/dmem` subsystem. The bug is clea= r and well-described: `page_counter_set_max()` can return `-EBUSY` when the= current usage exceeds the requested new max, but the return value was bein= g silently discarded by `set_resource_max()` (which returned `void`). The f= ix is straightforward and correct in approach =E2=80=94 propagate the error= from `page_counter_set_max()` back to userspace. The patch is small, well-scoped, and the commit message includes a nice bef= ore/after demonstration. Overall this is a good bugfix. --- Generated by Claude Code Patch Reviewer