From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Date: Sun, 22 Mar 2026 04:52:39 +1000 Message-ID: In-Reply-To: <20260318-dsi-rgb101010-support-v2-0-698b7612eaeb@pm.me> References: <20260318-dsi-rgb101010-support-v2-0-698b7612eaeb@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Author: Alexander Koskovich Patches: 12 Reviewed: 2026-03-22T04:52:39.673001 --- This 3-patch series adds MIPI DSI RGB101010 (30bpp/10-bit) pixel format sup= port to the MSM DSI driver and fixes a DSC timing calculation for non-8-bit= panels. The series is well-motivated (enabling 10-bit panels like the BOE = BF068MWM-TD0) and the approach is generally sound, but there are a few issu= es to address. **Key concerns:** 1. **Patch 1**: Adding the new enum value at the **beginning** of the enum = rather than the end is unconventional and fragile, even though current user= s only switch on symbolic names. 2. **Patch 3**: A parallel formula in `dsi_host.c:591` (`dsi_adjust_pclk_fo= r_compression`) uses the same `bits_per_component * 3` divisor but is not a= ddressed =E2=80=94 this should be investigated for consistency. --- --- Generated by Claude Code Patch Reviewer