Claude review: drm/panthor: extend timestamp query with flags

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/panthor: extend timestamp query with flags
Author: Marcin Slusarz <marcin.slusarz@arm.com>
Patches: 16
Reviewed: 2026-03-22T04:24:21.326403

---

This mbox contains three versions (v1, v2, v3) of the same patch: "drm/panthor: extend timestamp query with flags". The patch extends the `DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO` ioctl to support flags that let userspace selectively request GPU timestamps, CPU timestamps (CLOCK_MONOTONIC or CLOCK_MONOTONIC_RAW), GPU cycle counts, and query duration measurement. The motivation is to improve `VK_KHR_calibrated_timestamps` support. I'll focus the detailed review on **v3** as the latest version, with notes on the evolution.

The overall approach is reasonable — extending an existing query struct with flags and new fields while maintaining backward compatibility. However, there are several concerns around the UAPI design, the `timens_add_monotonic` usage with interrupts disabled, and the `copy_struct_from_user` interaction with panthor's existing UOBJ infrastructure.

---
Generated by Claude Code Patch Reviewer