From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: extend timestamp query with flags Date: Sun, 22 Mar 2026 04:24:21 +1000 Message-ID: In-Reply-To: <20260318112952.645160-1-marcin.slusarz@arm.com> References: <20260318112952.645160-1-marcin.slusarz@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panthor: extend timestamp query with flags Author: Marcin Slusarz Patches: 16 Reviewed: 2026-03-22T04:24:21.326403 --- This mbox contains three versions (v1, v2, v3) of the same patch: "drm/pant= hor: extend timestamp query with flags". The patch extends the `DRM_PANTHOR= _DEV_QUERY_TIMESTAMP_INFO` ioctl to support flags that let userspace select= ively request GPU timestamps, CPU timestamps (CLOCK_MONOTONIC or CLOCK_MONO= TONIC_RAW), GPU cycle counts, and query duration measurement. The motivatio= n is to improve `VK_KHR_calibrated_timestamps` support. I'll focus the deta= iled review on **v3** as the latest version, with notes on the evolution. The overall approach is reasonable =E2=80=94 extending an existing query st= ruct with flags and new fields while maintaining backward compatibility. Ho= wever, there are several concerns around the UAPI design, the `timens_add_m= onotonic` usage with interrupts disabled, and the `copy_struct_from_user` i= nteraction with panthor's existing UOBJ infrastructure. --- Generated by Claude Code Patch Reviewer