Claude review: gpu: nova-core: gsp: fix undefined behavior in command queue code

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: nova-core: gsp: fix undefined behavior in command queue code
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 4
Reviewed: 2026-03-22T04:48:51.690847

---

This is a single-patch fix for undefined behavior in the nova-core GSP command queue code. The problem is real and well-identified: the old code creates Rust references (`&` / `&mut`) to the entire `GspMem` shared memory structure (via `as_slice`/`as_slice_mut`), which includes regions concurrently owned by the GSP. Under Rust's aliasing model, creating a reference to memory that may be concurrently modified — even if you never actually access those parts — is undefined behavior.

The fix correctly replaces this with raw pointer arithmetic (`&raw mut` / `&raw const` + `start_ptr_mut()`/`start_ptr()`), only materializing safe slices over the driver-owned regions. The approach is sound and the safety reasoning is well-documented.

**Verdict: The patch is correct and should be accepted.** A few minor observations below.

---
Generated by Claude Code Patch Reviewer