From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: cgroup/dmem: allow atomic irrestrictive writes to dmem.max
Date: Sun, 22 Mar 2026 04:08:55 +1000 [thread overview]
Message-ID: <review-overall-20260319-dmem_max_ebusy-v2-0-b5ce97205269@igalia.com> (raw)
In-Reply-To: <20260319-dmem_max_ebusy-v2-0-b5ce97205269@igalia.com>
Overall Series Review
Subject: cgroup/dmem: allow atomic irrestrictive writes to dmem.max
Author: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Patches: 4
Reviewed: 2026-03-22T04:08:55.621521
---
This is a clean, well-motivated 3-patch series that fixes a real bug in the dmem cgroup controller: writes to `dmem.max` were silently failing when usage exceeded the new limit (because `page_counter_set_max` returns `-EBUSY` which was ignored). The series also addresses an atomicity issue with multi-region writes.
The approach is sound: simplify the write path to single-region-per-write, then replace `page_counter_set_max()` with a direct `xchg()` to unconditionally set the limit. The patches are well-ordered and each does one logical thing. The code after the series is simpler and more correct.
No significant issues found.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-21 18:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 21:22 [PATCH v2 0/3] cgroup/dmem: allow atomic irrestrictive writes to dmem.max Thadeu Lima de Souza Cascardo
2026-03-19 21:22 ` [PATCH v2 1/3] cgroup/dmem: remove region parameter from dmemcg_parse_limit Thadeu Lima de Souza Cascardo
2026-03-21 18:08 ` Claude review: " Claude Code Review Bot
2026-03-19 21:22 ` [PATCH v2 2/3] cgroup/dmem: accept a single region when writing to attributes Thadeu Lima de Souza Cascardo
2026-03-21 18:08 ` Claude review: " Claude Code Review Bot
2026-03-19 21:22 ` [PATCH v2 3/3] cgroup/dmem: allow max to be set below current usage Thadeu Lima de Souza Cascardo
2026-03-21 18:08 ` Claude review: " Claude Code Review Bot
2026-03-21 18:08 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260319-dmem_max_ebusy-v2-0-b5ce97205269@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox