From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: cgroup/dmem: allow atomic irrestrictive writes to dmem.max Date: Sun, 22 Mar 2026 04:08:55 +1000 Message-ID: In-Reply-To: <20260319-dmem_max_ebusy-v2-0-b5ce97205269@igalia.com> References: <20260319-dmem_max_ebusy-v2-0-b5ce97205269@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: cgroup/dmem: allow atomic irrestrictive writes to dmem.max Author: Thadeu Lima de Souza Cascardo Patches: 4 Reviewed: 2026-03-22T04:08:55.621521 --- This is a clean, well-motivated 3-patch series that fixes a real bug in the dmem cgroup controller: writes to `dmem.max` were silently failing when usage exceeded the new limit (because `page_counter_set_max` returns `-EBUSY` which was ignored). The series also addresses an atomicity issue with multi-region writes. The approach is sound: simplify the write path to single-region-per-write, then replace `page_counter_set_max()` with a direct `xchg()` to unconditionally set the limit. The patches are well-ordered and each does one logical thing. The code after the series is simpler and more correct. No significant issues found. --- Generated by Claude Code Patch Reviewer