From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Date: Sun, 22 Mar 2026 04:21:56 +1000 Message-ID: In-Reply-To: <20260319-dsi-rgb101010-support-v3-0-85b99df2d090@pm.me> References: <20260319-dsi-rgb101010-support-v3-0-85b99df2d090@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Author: Alexander Koskovich Patches: 34 Reviewed: 2026-03-22T04:21:56.135972 --- This is a 4-patch series adding RGB101010 (30bpp) pixel format support to the Qualcomm MSM DSI driver and fixing a DSC timing calculation bug for non-8-bit panels. The series is well-structured: fix a naming typo first, add a helper, add the feature, then fix the exposed bug. **Key concern:** The series depends on `MIPI_DSI_FMT_RGB101010` existing in the `enum mipi_dsi_pixel_format` in `include/drm/drm_mipi_dsi.h`, but this enum value does not exist in the current kernel tree. This means there must be a prerequisite patch (or series) that adds this format to the core DRM DSI subsystem. The series should explicitly mention this dependency in the cover letter, or include the prerequisite patch. The version rename (patch 1) and DSC timing fix (patch 4) are independently useful and correct. The helper (patch 2) and RGB101010 support (patch 3) are clean. --- Generated by Claude Code Patch Reviewer