Claude review: drm/msm/hdmi & phy: use generic PHY framework

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/msm/hdmi & phy: use generic PHY framework
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 5
Reviewed: 2026-03-22T04:56:09.000836

---

This series migrates the MSM HDMI PHY drivers from ad-hoc DRM subsystem integration to the Linux generic PHY framework, moving the PHY implementations from `drivers/gpu/drm/msm/hdmi/` to `drivers/phy/qualcomm/`. This is a well-motivated architectural change — it decouples the PHY hardware programming from the display driver, follows established kernel patterns, and enables PHY reuse across subsystems.

The series is structured logically: patch 1 does the bulk migration, patches 2-3 prepare shared register definitions, and patch 4 adds PLL support for MSM8974. The code is generally clean and well-organized.

**Critical issues:**
- **Missing compatible strings**: `qcom,hdmi-phy-8084` (was mapped to `msm_hdmi_phy_8x74_cfg`) and `qcom,hdmi-phy-8998` (was handled in old QMP code) are absent from the new driver match tables. This will break HDMI on APQ8084 and MSM8998 platforms.
- **Unit mismatch in patch 4**: `tmds_char_rate` in `struct phy_configure_opts_hdmi` is in Hz, but the PLL rate calculations and comparisons like `pixclk == 297000` appear to expect kHz.

**Minor issues:**
- Typos in Kconfig/MODULE_DESCRIPTION
- Code duplication of `write16`/`write24`/`read24` helpers
- Use of `of_device_get_match_data()` instead of the preferred `device_get_match_data()`

---

---
Generated by Claude Code Patch Reviewer