From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/hdmi & phy: use generic PHY framework Date: Sun, 22 Mar 2026 04:56:09 +1000 Message-ID: In-Reply-To: <20260319-fd-hdmi-phy-v6-0-cefc08a55470@oss.qualcomm.com> References: <20260319-fd-hdmi-phy-v6-0-cefc08a55470@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/hdmi & phy: use generic PHY framework Author: Dmitry Baryshkov Patches: 5 Reviewed: 2026-03-22T04:56:09.000836 --- This series migrates the MSM HDMI PHY drivers from ad-hoc DRM subsystem int= egration to the Linux generic PHY framework, moving the PHY implementations= from `drivers/gpu/drm/msm/hdmi/` to `drivers/phy/qualcomm/`. This is a wel= l-motivated architectural change =E2=80=94 it decouples the PHY hardware pr= ogramming from the display driver, follows established kernel patterns, and= enables PHY reuse across subsystems. The series is structured logically: patch 1 does the bulk migration, patche= s 2-3 prepare shared register definitions, and patch 4 adds PLL support for= MSM8974. The code is generally clean and well-organized. **Critical issues:** - **Missing compatible strings**: `qcom,hdmi-phy-8084` (was mapped to `msm_= hdmi_phy_8x74_cfg`) and `qcom,hdmi-phy-8998` (was handled in old QMP code) = are absent from the new driver match tables. This will break HDMI on APQ808= 4 and MSM8998 platforms. - **Unit mismatch in patch 4**: `tmds_char_rate` in `struct phy_configure_o= pts_hdmi` is in Hz, but the PLL rate calculations and comparisons like `pix= clk =3D=3D 297000` appear to expect kHz. **Minor issues:** - Typos in Kconfig/MODULE_DESCRIPTION - Code duplication of `write16`/`write24`/`read24` helpers - Use of `of_device_get_match_data()` instead of the preferred `device_get_= match_data()` --- --- Generated by Claude Code Patch Reviewer