From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Add "link bpc" DRM property
Date: Sun, 22 Mar 2026 04:19:39 +1000 [thread overview]
Message-ID: <review-overall-20260319-link-bpc-v5-0-5306cd04a708@collabora.com> (raw)
In-Reply-To: <20260319-link-bpc-v5-0-5306cd04a708@collabora.com>
Overall Series Review
Subject: Add "link bpc" DRM property
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Patches: 7
Reviewed: 2026-03-22T04:19:39.991011
---
This 3-patch series adds a new immutable "link bpc" DRM connector property that exposes the actual bits-per-component achieved on the display link after any driver-side degradation (e.g., for bandwidth). The design is reasonable and the split is clean: patch 1 adds the core infrastructure, patch 2 wires it into the HDMI state helpers, and patch 3 adds amdgpu support.
The main concern is **timing of the property update and uevent**: the link_bpc property is updated and the uevent is fired in `commit_tail()` *before* `atomic_commit_tail()` programs the hardware. This means userspace is notified of the new link_bpc before the display has actually switched to it. There are also a couple of minor issues noted below.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 12:28 [PATCH v5 0/3] Add "link bpc" DRM property Nicolas Frattaroli
2026-03-19 12:28 ` [PATCH v5 1/3] drm/connector: Add a 'link bpc' property Nicolas Frattaroli
2026-03-21 18:19 ` Claude review: " Claude Code Review Bot
2026-03-19 12:28 ` [PATCH v5 2/3] drm/connector: hdmi: Add support for " Nicolas Frattaroli
2026-03-21 18:19 ` Claude review: " Claude Code Review Bot
2026-03-19 12:28 ` [PATCH v5 3/3] drm/amd/display: " Nicolas Frattaroli
2026-03-21 18:19 ` Claude review: " Claude Code Review Bot
2026-03-20 14:32 ` [PATCH v5 0/3] Add "link bpc" DRM property Michel Dänzer
2026-03-20 18:02 ` Nicolas Frattaroli
2026-03-21 2:33 ` Mario Kleiner
2026-03-21 18:19 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-11 11:30 [PATCH v4 0/2] " Nicolas Frattaroli
2026-03-11 20:57 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260319-link-bpc-v5-0-5306cd04a708@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox