From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add "link bpc" DRM property Date: Sun, 22 Mar 2026 04:19:39 +1000 Message-ID: In-Reply-To: <20260319-link-bpc-v5-0-5306cd04a708@collabora.com> References: <20260319-link-bpc-v5-0-5306cd04a708@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add "link bpc" DRM property Author: Nicolas Frattaroli Patches: 7 Reviewed: 2026-03-22T04:19:39.991011 --- This 3-patch series adds a new immutable "link bpc" DRM connector property that exposes the actual bits-per-component achieved on the display link after any driver-side degradation (e.g., for bandwidth). The design is reasonable and the split is clean: patch 1 adds the core infrastructure, patch 2 wires it into the HDMI state helpers, and patch 3 adds amdgpu support. The main concern is **timing of the property update and uevent**: the link_bpc property is updated and the uevent is fired in `commit_tail()` *before* `atomic_commit_tail()` programs the hardware. This means userspace is notified of the new link_bpc before the display has actually switched to it. There are also a couple of minor issues noted below. --- --- Generated by Claude Code Patch Reviewer