From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/shmem-helper: Fix huge page mapping in fault handler
Date: Sun, 22 Mar 2026 04:58:23 +1000 [thread overview]
Message-ID: <review-overall-20260319015224.46896-1-pedrodemargomes@gmail.com> (raw)
In-Reply-To: <20260319015224.46896-1-pedrodemargomes@gmail.com>
Overall Series Review
Subject: drm/shmem-helper: Fix huge page mapping in fault handler
Author: Pedro Demarchi Gomes <pedrodemargomes@gmail.com>
Patches: 2
Reviewed: 2026-03-22T04:58:23.495148
---
This is a single-patch fix for a real race condition in `drm_gem_shmem_helper.c` where two concurrent page faults within the same PMD range can conflict — one installing a PMD mapping via `vmf_insert_pfn_pmd()` while the other attempts a PTE mapping via `vmf_insert_pfn()`, triggering a BUG in `walk_to_pmd()`.
The fundamental approach is correct: adding a `.huge_fault` callback separates PMD-level faults from PTE-level faults, letting the MM core route them through the proper path (`create_huge_pmd()` at mm/memory.c:6417 only calls `.huge_fault` when `pmd_none()` is true). However, this patch is based on an older tree and **does not apply to drm-next**, which has already refactored this code significantly (adding `drm_gem_shmem_try_insert_pfn_pmd`, `folio_mark_accessed`, `pfn_mkwrite` callback, etc.). The patch needs to be rebased.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 1:52 [PATCH v4] drm/shmem-helper: Fix huge page mapping in fault handler Pedro Demarchi Gomes
2026-03-19 8:09 ` Boris Brezillon
2026-03-21 18:58 ` Claude Code Review Bot [this message]
2026-03-21 18:58 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260319015224.46896-1-pedrodemargomes@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox