public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: shmobile: Fix white screen after resume when LCDC is stopped
Date: Sun, 22 Mar 2026 04:28:52 +1000	[thread overview]
Message-ID: <review-overall-20260319083207.17195-1-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260319083207.17195-1-phucduc.bui@gmail.com>

Overall Series Review

Subject: drm: shmobile: Fix white screen after resume when LCDC is stopped
Author: phucduc.bui@gmail.com
Patches: 1
Reviewed: 2026-03-22T04:28:52.005399

---

This is a single, well-motivated bugfix patch for the shmobile LCDC driver. The problem is clearly described: after suspend/resume, both register sets (A and B) are reset to 0, but the original code only wrote to the mirror (Set B) and relied on a Frame End interrupt to trigger the hardware register switching. When the controller is stopped (DO=0), no Frame End interrupt occurs, so Set A stays at 0 and the display shows white.

The fix is correct and minimal. It checks whether the display output is active (LDCNT2R_DO) and uses the appropriate write path:
- **DO=1 (running):** Use `lcdc_write_mirror()` + toggle `LDRCNTR_MRS` as before (the normal double-buffered update path).
- **DO=0 (stopped):** Use `lcdc_write()` which writes to both Set A and Set B directly, ensuring valid addresses are present when output is re-enabled.

The patch has Tested-by and Reviewed-by from the subsystem maintainer (Geert Uytterhoeven). It looks ready to merge.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-21 18:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  8:31 [PATCH v3] drm: shmobile: Fix white screen after resume when LCDC is stopped phucduc.bui
2026-03-21 18:28 ` Claude Code Review Bot [this message]
2026-03-21 18:28 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260319083207.17195-1-phucduc.bui@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox