[PATCH V2 for drm-misc-fixes] MAINTAINERS: split hisilicon maintenance and add Yongbang Shi for hibmc-drm matainers

[PATCH V2 for drm-misc-fixes] MAINTAINERS: split hisilicon maintenance and add Yongbang Shi for hibmc-drm matainers

[Yongbang Shi]

To improve maintainability, split the maintainer information for the hibmc and
kirin drivers under the drivers/gpu/drm/hisilicon directory.

drivers/gpu/drm/hisilicon/hibmc driver has almost completed feature development
based on the new generation HiSilicon BMC chip. It was co-developed by
Yongbang Shi, Baihan Li and Lin He. Going forward, this module will be
maintained by Yongbang Shi.

Signed-off-by: Yongbang Shi <shiyongbang@huawei.com>
Acked-by: Tao Tian <tiantao6@hisilicon.com>
Acked-by: Xinliang Liu <xinliang.liu@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---

ChangeLog:
V1 -> V2:
  - remove Xinliang Liu, Sumit Semwal, Yongqin Liu, and John Stultz from DRM DRIVERS
    FOR HISILICON HIBMC
  - remove Tian Tao and Xinwei Kong from DRM DRIVERS FOR HISILICON KIRIN

---
 MAINTAINERS | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index d7241695df96..7c0bdd7b8f08 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8603,18 +8603,25 @@ S:	Maintained
 T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
 F:	drivers/gpu/drm/gma500/
 
-DRM DRIVERS FOR HISILICON
-M:	Xinliang Liu <xinliang.liu@linaro.org>
-M:	Tian Tao  <tiantao6@hisilicon.com>
-R:	Xinwei Kong <kong.kongxinwei@hisilicon.com>
-R:	Sumit Semwal <sumit.semwal@linaro.org>
-R:	Yongqin Liu <yongqin.liu@linaro.org>
-R:	John Stultz <jstultz@google.com>
-L:	dri-devel@lists.freedesktop.org
-S:	Maintained
-T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
-F:	Documentation/devicetree/bindings/display/hisilicon/
-F:	drivers/gpu/drm/hisilicon/
+DRM DRIVERS FOR HISILICON HIBMC
+M:      Yongbang Shi <shiyongbang@huawei.com>
+M:      Tian Tao  <tiantao6@hisilicon.com>
+R:      Xinwei Kong <kong.kongxinwei@hisilicon.com>
+L:      dri-devel@lists.freedesktop.org
+S:      Maintained
+T:      git https://gitlab.freedesktop.org/drm/misc/kernel.git
+F:      drivers/gpu/drm/hisilicon/hibmc
+
+DRM DRIVERS FOR HISILICON KIRIN
+M:      Xinliang Liu <xinliang.liu@linaro.org>
+R:      Sumit Semwal <sumit.semwal@linaro.org>
+R:      Yongqin Liu <yongqin.liu@linaro.org>
+R:      John Stultz <jstultz@google.com>
+L:      dri-devel@lists.freedesktop.org
+S:      Maintained
+T:      git https://gitlab.freedesktop.org/drm/misc/kernel.git
+F:      Documentation/devicetree/bindings/display/hisilicon/
+F:      drivers/gpu/drm/hisilicon/kirin
 
 DRM DRIVERS FOR LIMA
 M:	Qiang Yu <yuq825@gmail.com>
-- 
2.33.0

Claude review: MAINTAINERS: split hisilicon maintenance and add Yongbang Shi for hibmc-drm matainers

[Claude Code Review Bot]

Overall Series Review

Subject: MAINTAINERS: split hisilicon maintenance and add Yongbang Shi for hibmc-drm matainers
Author: Yongbang Shi <shiyongbang@huawei.com>
Patches: 1
Reviewed: 2026-03-22T04:17:00.719092

---

This is a single-patch MAINTAINERS update that splits the combined "DRM DRIVERS FOR HISILICON" entry into two separate entries for the hibmc and kirin sub-drivers. The intent is reasonable — hibmc and kirin are distinct drivers with different maintainer groups, and splitting them improves clarity.

The patch has appropriate Acked-by tags from the existing maintainers (Tian Tao, Xinliang Liu, Thomas Zimmermann). However, there is a significant formatting problem and a couple of content concerns.

---
Generated by Claude Code Patch Reviewer

Claude review: MAINTAINERS: split hisilicon maintenance and add Yongbang Shi for hibmc-drm matainers

[Claude Code Review Bot]

Patch Review

**Typo in subject:** "matainers" should be "maintainers".

**Critical: Whitespace formatting is wrong.** The MAINTAINERS file uses **tabs** after the field tag (e.g., `M:\t`), as confirmed by the existing file. The patch replaces all tab-separated lines with **spaces**:

```
-M:	Xinliang Liu <xinliang.liu@linaro.org>
+M:      Yongbang Shi <shiyongbang@huawei.com>
```

The `+` lines use spaces (likely 6 spaces) instead of a tab character. This will cause `scripts/get_maintainer.pl` and checkpatch.pl to complain, and is inconsistent with every other entry in MAINTAINERS. All lines must use a tab after the colon, not spaces.

**Missing F: path trailing slash.** The file path entries lack trailing slashes for directories:

```
+F:      drivers/gpu/drm/hisilicon/hibmc
+F:      drivers/gpu/drm/hisilicon/kirin
```

The MAINTAINERS convention for directories is to include a trailing `/` (e.g., `F: drivers/gpu/drm/hisilicon/hibmc/`). Without it, `get_maintainer.pl` may not match files within the directory correctly. The existing entry uses `F: drivers/gpu/drm/hisilicon/` with a trailing slash.

**Documentation/devicetree/bindings coverage.** The DT bindings path `Documentation/devicetree/bindings/display/hisilicon/` is only assigned to the KIRIN section. If hibmc also has (or will have) DT bindings under that path, they would have no maintainer coverage. Currently this seems reasonable since hibmc is a BMC (server management) driver that likely doesn't use DT, but it's worth confirming.

**Tian Tao remains M: for HIBMC but was removed from original entry in V1→V2 changelog context.** The changelog says "remove Tian Tao and Xinwei Kong from DRM DRIVERS FOR HISILICON KIRIN," and indeed they are only listed under HIBMC. This seems intentional and fine — just noting for clarity.

**Summary of required fixes:**
1. Fix subject typo: "matainers" → "maintainers"
2. Use tabs (not spaces) after field tags on all new lines
3. Add trailing `/` to directory paths in `F:` entries (`hibmc/`, `kirin/`)

---
Generated by Claude Code Patch Reviewer