From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mipi-dbi: Replace simple-display helpers with regular atomic helpers Date: Sun, 22 Mar 2026 04:15:32 +1000 Message-ID: In-Reply-To: <20260319160110.109610-1-tzimmermann@suse.de> References: <20260319160110.109610-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/mipi-dbi: Replace simple-display helpers with regular atomic helpers Author: Thomas Zimmermann Patches: 17 Reviewed: 2026-03-22T04:15:32.729051 --- This is a well-structured 16-patch series by Thomas Zimmermann that converts all mipi-dbi based DRM drivers from the `drm_simple_display_pipe` abstraction to regular atomic modesetting helpers. The motivation is sound: simple-display-pipe helpers have been a source of confusion for new driver authors and add an unnecessary intermediate layer. The series is v3 with review from David Lechner (Acked-by on all patches). The overall approach is clean: 1. Fix the commit-tail ordering so plane updates happen after CRTC enable (patch 1) 2. Factor out device init from pipeline init (patch 2) 3. Provide macro-based initializers for atomic helpers (patch 3) 4. Convert each driver individually (patches 4-14) 5. Remove the now-unused simple-display code from mipi-dbi (patch 15) 6. Deprecate simple-kms helpers project-wide (patch 16) The conversion pattern is consistent and mechanical across all drivers. There are a few minor issues noted below, but nothing that would block merging. The series has already been acked by the relevant reviewer. --- Generated by Claude Code Patch Reviewer