From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Split Generic PHY consumer and provider API Date: Sun, 22 Mar 2026 04:07:11 +1000 Message-ID: In-Reply-To: <20260319223241.1351137-1-vladimir.oltean@nxp.com> References: <20260319223241.1351137-1-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Split Generic PHY consumer and provider API Author: Vladimir Oltean Patches: 30 Reviewed: 2026-03-22T04:07:11.167937 --- This is a well-structured 27-patch series by Vladimir Oltean that splits the Generic PHY subsystem's `` into separate consumer and provider APIs. The goal is to make `struct phy` opaque to consumer drivers, following the pattern of other subsystems (GPIO, IIO, regulator, etc.). The series is at v5 and has collected several review tags. **Architecture**: The approach is sound -- preparatory patches (01-14) fix transitive include dependencies and eliminate consumer drivers' direct access to `struct phy` internals, then the core split (15) creates `drivers/phy/phy-provider.h` and `include/linux/phy/phy-props.h`, followed by migration patches (16-25) and cleanup (26-27). **Quality**: The series is thorough and carefully ordered. The temporary backward-compatibility include in patch 15 (removed in patch 26) allows bisectability. The commit messages are detailed, well-reasoned, and honest about known issues (e.g., the rswitch FIXME in patch 21). **DRM impact**: Patches 04, 11, 14, 17-19 touch DRM code. All are straightforward and correct. No functional issues found. **Concerns**: Minor -- see per-patch notes below. Overall this is ready to merge. --- Generated by Claude Code Patch Reviewer