Claude review: drm/imagination: GPU_ID-related cleanups

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/imagination: GPU_ID-related cleanups
Author: Matt Coster <matt.coster@imgtec.com>
Patches: 3
Reviewed: 2026-03-22T03:38:20.530354

---

This is a clean, well-structured 2-patch series that makes quality-of-life improvements to the PowerVR GPU ID (BVNC) handling in the Imagination DRM driver. 

**Patch 1** moves the packed BVNC field layout definitions into the UAPI header as `DRM_PVR_BVNC_*` macros using `__GENMASK_ULL()`, replacing duplicated ASCII-art layout comments scattered throughout the code. It also switches the internal packing/unpacking to use `FIELD_PREP`/`FIELD_GET`, and adds a `FIELD_PREP_CONST` variant to fix compile-time constant issues in `case` statements (addressing v1 build failures).

**Patch 2** introduces `PVR_GPU_ID_FMT` / `PVR_GPU_ID_FMT_ARGS()` / `PVR_GPU_ID_FMT_ARGS_PACKED()` macros for consistent printf formatting of GPU IDs, fixing a minor inconsistency where `%i` and `%d` were used for `u16` fields (should be `%u`).

The series is well-motivated, addresses real code duplication and correctness issues, and has no functional changes beyond the format specifier fix. The UAPI change is purely additive (new macros, no ABI breakage). **Recommend merge.**

---
Generated by Claude Code Patch Reviewer