From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Date: Sun, 22 Mar 2026 03:48:36 +1000 Message-ID: In-Reply-To: <20260320-drm-lcdif-dbanc-v1-0-479a04133e70@bootlin.com> References: <20260320-drm-lcdif-dbanc-v1-0-479a04133e70@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Author: Luca Ceresoli Patches: 10 Reviewed: 2026-03-22T03:48:36.879364 --- This is a well-structured and well-motivated series that modernizes the i.MX8MP LCDIF driver to use `DRM_BRIDGE_ATTACH_NO_CONNECTOR` with `drm_bridge_connector`, which is the current DRM best practice. The cover letter is excellent and clearly explains the dependency chain between patches. The backward compatibility approach using a DT overlay (patch 7) is a reasonable reuse of the pattern from `drm/tilcdc`. There is one clear bug in patch 1 (wrong cleanup type), and a few minor issues in other patches. The core changes in patches 6 and 8 look correct and well-reasoned. --- Generated by Claude Code Patch Reviewer