From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: Rework initial state allocation Date: Sun, 22 Mar 2026 03:32:25 +1000 Message-ID: In-Reply-To: <20260320-drm-mode-config-init-v2-0-c63f1134e76c@kernel.org> References: <20260320-drm-mode-config-init-v2-0-c63f1134e76c@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: Rework initial state allocation Author: Maxime Ripard Patches: 21 Reviewed: 2026-03-22T03:32:25.244110 --- This is a well-structured series by Maxime Ripard that introduces a new `atomic_create_state` callback pattern for DRM objects (plane, crtc, connector), following the precedent already established for `drm_private_obj`. The goal is to separate the concerns of "allocate initial pristine state" from "reset hardware/software state" which are currently conflated in the `reset()` callback. The series is logically ordered: doc fixes and cleanups first, then renaming `_state_reset` to `_state_init`, then adding the new callbacks per object type, creating `drm_mode_config_create_state()`, hooking it into `drm_dev_register()`, and finally converting two example drivers (tidss, bridge_connector). There are a few issues worth flagging, most notably around error handling cleanup in `drm_mode_config_create_state()` and the redundancy of some wrapper functions. --- Generated by Claude Code Patch Reviewer