public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Use seq_puts() for fixed string output
Date: Sun, 22 Mar 2026 03:54:18 +1000	[thread overview]
Message-ID: <review-overall-20260320073129.145575-1-liuqiangneo@163.com> (raw)
In-Reply-To: <20260320073129.145575-1-liuqiangneo@163.com>

Overall Series Review

Subject: drm: Use seq_puts() for fixed string output
Author: liuqiangneo@163.com
Patches: 3
Reviewed: 2026-03-22T03:54:18.233754

---

This is a straightforward mechanical cleanup series that replaces `seq_printf()` with `seq_puts()` when printing constant strings (no format specifiers). The changes are correct and follow a well-established kernel coding convention. The series has no functional impact — `seq_puts()` simply avoids unnecessary format string parsing overhead.

The patches are clean, properly split by file/subsystem, and correctly described. No issues found.

**Verdict: Acceptable for merge.**

One minor note: `seq_printf(m, "\n")` could also be replaced with `seq_putc(m, '\n')` for a single character, but `seq_puts()` is fine too and consistent with the other changes in the series.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-21 17:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20  7:31 [PATCH 0/2] drm: Use seq_puts() for fixed string output liuqiangneo
2026-03-20  7:31 ` [PATCH 1/2] drm/debugfs: Replace seq_printf with seq_puts for constant strings liuqiangneo
2026-03-21 17:54   ` Claude review: " Claude Code Review Bot
2026-03-20  7:31 ` [PATCH 2/2] drm/dp_mst: " liuqiangneo
2026-03-21 17:54   ` Claude review: " Claude Code Review Bot
2026-03-21 17:54 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260320073129.145575-1-liuqiangneo@163.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox