From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/shmem_helper: Make sure PMD entries get the writeable upgrade
Date: Sun, 22 Mar 2026 03:39:52 +1000 [thread overview]
Message-ID: <review-overall-20260320151914.586945-1-boris.brezillon@collabora.com> (raw)
In-Reply-To: <20260320151914.586945-1-boris.brezillon@collabora.com>
Overall Series Review
Subject: drm/shmem_helper: Make sure PMD entries get the writeable upgrade
Author: Boris Brezillon <boris.brezillon@collabora.com>
Patches: 2
Reviewed: 2026-03-22T03:39:52.517246
---
This is a single-patch fix for a real bug: PMD (huge page) entries in the shmem GEM helper were never upgraded to writeable because `vmf_insert_pfn_pmd()` was always called with `write=false`, and `.pfn_mkwrite()` is not invoked for PMD write-upgrade faults (only `.huge_fault()` is). The fix correctly passes the write flag through and records the dirty state in the PMD path. The logic is sound. However, there is a regression in error handling that should be addressed.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 15:19 [PATCH] drm/shmem_helper: Make sure PMD entries get the writeable upgrade Boris Brezillon
2026-03-20 16:38 ` Tommaso Merciai
2026-03-21 17:39 ` Claude Code Review Bot [this message]
2026-03-21 17:39 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260320151914.586945-1-boris.brezillon@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox