From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/shmem_helper: Make sure PMD entries get the writeable upgrade Date: Sun, 22 Mar 2026 03:39:52 +1000 Message-ID: In-Reply-To: <20260320151914.586945-1-boris.brezillon@collabora.com> References: <20260320151914.586945-1-boris.brezillon@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/shmem_helper: Make sure PMD entries get the writeable upgrade Author: Boris Brezillon Patches: 2 Reviewed: 2026-03-22T03:39:52.517246 --- This is a single-patch fix for a real bug: PMD (huge page) entries in the shmem GEM helper were never upgraded to writeable because `vmf_insert_pfn_pmd()` was always called with `write=false`, and `.pfn_mkwrite()` is not invoked for PMD write-upgrade faults (only `.huge_fault()` is). The fix correctly passes the write flag through and records the dirty state in the PMD path. The logic is sound. However, there is a regression in error handling that should be addressed. --- Generated by Claude Code Patch Reviewer