From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register Date: Sun, 22 Mar 2026 03:36:31 +1000 Message-ID: In-Reply-To: <20260320153753.25450-1-l.scorcia@gmail.com> References: <20260320153753.25450-1-l.scorcia@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register Author: Luca Leonardo Scorcia Patches: 1 Reviewed: 2026-03-22T03:36:31.537150 --- This is a single-patch fix for a real NULL pointer dereference crash in the MediaTek DSI driver during probe. The analysis is correct and the fix is straightforward. The commit `e4732b590a77` moved `mipi_dsi_host_register` earlier in the probe sequence but left `platform_set_drvdata` after it, causing `dev_get_drvdata` in the `mtk_dsi_bind` callback path to return NULL. The patch is well-motivated with a clear crash trace, has already been reviewed by the MediaTek DRM maintainers (CK Hu) and Collabora's Angelo Del Regno, and is on its v3 iteration. **Verdict: Looks good. Ready to merge.** --- Generated by Claude Code Patch Reviewer