From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Date: Sun, 22 Mar 2026 03:27:29 +1000 Message-ID: In-Reply-To: <20260320183547.61017-6-jonathan.cavitt@intel.com> References: <20260320183547.61017-6-jonathan.cavitt@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Author: Jonathan Cavitt Patches: 5 Reviewed: 2026-03-22T03:27:29.473314 --- This v38 series adds a new `DRM_IOCTL_XE_VM_GET_PROPERTY` ioctl to the xe driver, initially supporting a `FAULTS` property that lets userspace retrieve up to 50 failed pagefaults per VM. The series is structured logically: (1) fix read-only VMA write rejection, (2) define uAPI, (3) add per-VM fault tracking, (4) implement the ioctl. The series has been through extensive review (38 revisions) and has multiple R-b/Ack tags. However, there are several issues remaining, including a **bug in patch 1** where the prefetch bit is not masked when comparing access types, **comma-instead-of-semicolon** style errors in patch 3, **missing MBZ validation** of `pad` and `extensions` fields in patch 4, and **uAPI naming concerns** in patch 2. --- Generated by Claude Code Patch Reviewer