From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma::Coherent & dma::CoherentBox API
Date: Sun, 22 Mar 2026 03:23:42 +1000
Message-ID: <review-overall-20260320194626.36263-1-dakr@kernel.org>
In-Reply-To: <20260320194626.36263-1-dakr@kernel.org>
References: <20260320194626.36263-1-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Overall Series Review

Subject: dma::Coherent & dma::CoherentBox API
Author: Danilo Krummrich <dakr@kernel.org>
Patches: 16
Reviewed: 2026-03-22T03:23:42.435939

---

This is a well-structured v2 series by Danilo Krummrich (with Gary Guo) that generalizes the Rust DMA coherent allocation API from a slice-only `CoherentAllocation<T>` to a more flexible `Coherent<T>` that supports both single objects and slices. It also introduces `CoherentBox<T>` for safe CPU-side initialization before exposing DMA memory to hardware, and adds `Coherent::init()` / `Coherent::init_with_attrs()` for one-shot pin-init construction. The nova-core driver is then converted to the new API.

The series is logically ordered with clean incremental steps. The design is sound: separating the "not yet shared with device" phase (`CoherentBox`) from the "device-visible" phase (`Coherent`) is a good pattern that eliminates several `unsafe` blocks in the driver code. Already has reviews from Alice Ryhl and Gary Guo on the core patches.

A few issues worth noting are called out per-patch below.

---
Generated by Claude Code Patch Reviewer