Claude review: accel/amdxdna: Refactor GEM BO handling and add helper APIs for address retrieval

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: accel/amdxdna: Refactor GEM BO handling and add helper APIs for address retrieval
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 3
Reviewed: 2026-03-22T03:20:50.763382

---

This is a single-patch refactor of the amdxdna GEM BO handling that introduces address-retrieval helper APIs (`amdxdna_gem_vmap`, `amdxdna_gem_uva`, `amdxdna_gem_dev_addr`) and merges the CMD BO type into SHMEM/SHARE. The goals are reasonable: centralizing address logic, removing the special CMD BO type, and preparing for future changes. However, there are several correctness concerns — particularly around concurrency in `amdxdna_gem_vmap()`, removal of the `.close` callback without preserving IOMMU cleanup symmetry, a lost size validation for CMD BOs, and an inconsistency in the ubuf DMA mapping change. The UAPI change to alias `AMDXDNA_BO_SHMEM = AMDXDNA_BO_SHARE = 1` is a reasonable backward-compat approach but deserves explicit documentation.

For a patch claiming "no functional change intended," this makes several behavioral changes (always DMA-mapping ubufs, removing CMD BO size checks, changing IOMMU map/unmap lifetime). It should either be split or the commit message should accurately describe the functional changes.

---

---
Generated by Claude Code Patch Reviewer