From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Date: Sun, 22 Mar 2026 03:12:28 +1000 Message-ID: In-Reply-To: <20260321-dsi-rgb101010-support-v4-0-eb28ecebbfe8@pm.me> References: <20260321-dsi-rgb101010-support-v4-0-eb28ecebbfe8@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Author: Alexander Koskovich Patches: 7 Reviewed: 2026-03-22T03:12:28.036134 --- This is a well-structured 5-patch series adding RGB101010 (30bpp) pixel format support for MIPI DSI, targeting MSM/Qualcomm DSI controllers v2.1.0+. The series is clean, logically ordered, and has already collected Reviewed-by tags from Dmitry Baryshkov and Konrad Dybcio. The version comparison helper and the version rename fix are good preparatory cleanup. One notable design point: `MIPI_DSI_FMT_RGB101010` is inserted at the **beginning** of the `mipi_dsi_pixel_format` enum, changing the implicit numeric values of all existing members. While kernel-internal enum usage is by symbolic name, appending at the end is the more conventional and conservative approach. This was presumably accepted by reviewers, so it may be intentional to sort by descending bpp. Overall: the series looks correct and ready to merge, with minor observations below. --- --- Generated by Claude Code Patch Reviewer