From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Deduplicate DCN DDC register assignment Date: Sun, 22 Mar 2026 03:15:10 +1000 Message-ID: In-Reply-To: <20260321015654.105059-1-guilhermeivob@gmail.com> References: <20260321015654.105059-1-guilhermeivob@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amd/display: Deduplicate DCN DDC register assignment Author: guilhermeivo Patches: 1 Reviewed: 2026-03-22T03:15:10.293141 --- This is a single-patch cleanup that deduplicates identical `define_ddc_regi= sters()` functions across 6 DCN generations into a shared `static inline` h= elper in a new header. The idea is sound and the deduplication is worthwhil= e =E2=80=94 the replaced code was truly identical in all 6 files. However, **the patch has a build-breaking type error** in the new shared he= lper and should not be merged as-is. --- Generated by Claude Code Patch Reviewer