From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/loongson: stop to set get_vblank_timestamp for LS7A1000 CRTC
Date: Sun, 22 Mar 2026 03:09:17 +1000 [thread overview]
Message-ID: <review-overall-20260321092804.3519447-1-zhengxingda@iscas.ac.cn> (raw)
In-Reply-To: <20260321092804.3519447-1-zhengxingda@iscas.ac.cn>
Overall Series Review
Subject: drm/loongson: stop to set get_vblank_timestamp for LS7A1000 CRTC
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Patches: 2
Reviewed: 2026-03-22T03:09:17.309159
---
This is a single-patch fix for a kernel warning on Loongson LS7A1000 hardware. The patch removes `.get_vblank_timestamp = drm_crtc_vblank_helper_get_vblank_timestamp` from `ls7a1000_crtc_funcs`, preventing the DRM core from attempting high-precision vblank timestamping on this CRTC.
The fix is reasonable as a pragmatic workaround but deserves some scrutiny — the LS7A1000 hardware **does** appear to have scan position registers (`LSDC_CRTC0_SCAN_POS_REG` / `LSDC_CRTC1_SCAN_POS_REG`) and the shared `lsdc_crtc_helper_funcs` still sets `.get_scanout_position = lsdc_crtc_get_scanout_position` for ls7a1000 CRTCs. So the hardware capability is there in some form.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 9:28 [PATCH v2] drm/loongson: stop to set get_vblank_timestamp for LS7A1000 CRTC Icenowy Zheng
2026-03-21 9:29 ` Icenowy Zheng
2026-03-21 17:09 ` Claude Code Review Bot [this message]
2026-03-21 17:09 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260321092804.3519447-1-zhengxingda@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox