From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/loongson: stop to set get_vblank_timestamp for LS7A1000 CRTC Date: Sun, 22 Mar 2026 03:09:17 +1000 Message-ID: In-Reply-To: <20260321092804.3519447-1-zhengxingda@iscas.ac.cn> References: <20260321092804.3519447-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/loongson: stop to set get_vblank_timestamp for LS7A1000 CRTC Author: Icenowy Zheng Patches: 2 Reviewed: 2026-03-22T03:09:17.309159 --- This is a single-patch fix for a kernel warning on Loongson LS7A1000 hardwa= re. The patch removes `.get_vblank_timestamp =3D drm_crtc_vblank_helper_get= _vblank_timestamp` from `ls7a1000_crtc_funcs`, preventing the DRM core from= attempting high-precision vblank timestamping on this CRTC. The fix is reasonable as a pragmatic workaround but deserves some scrutiny = =E2=80=94 the LS7A1000 hardware **does** appear to have scan position regis= ters (`LSDC_CRTC0_SCAN_POS_REG` / `LSDC_CRTC1_SCAN_POS_REG`) and the shared= `lsdc_crtc_helper_funcs` still sets `.get_scanout_position =3D lsdc_crtc_g= et_scanout_position` for ls7a1000 CRTCs. So the hardware capability is ther= e in some form. --- Generated by Claude Code Patch Reviewer