[PATCH v2] drm/amd/display: Fix DDC register assignment type errors

[PATCH v2] drm/amd/display: Fix DDC register assignment type errors

[guilhermeivo]

Fix invalid type assignments in ddc_sh_mask.

Signed-off-by: guilhermeivo <guilhermeivob@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603221553.GzXoxzCw-lkp@intel.com/
---
 drivers/gpu/drm/amd/display/dc/gpio/hw_factory_dcn_ddc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_factory_dcn_ddc.h b/drivers/gpu/drm/amd/display/dc/gpio/hw_factory_dcn_ddc.h
index 1f2bc7eea82e..863177cf67e8 100644
--- a/drivers/gpu/drm/amd/display/dc/gpio/hw_factory_dcn_ddc.h
+++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_factory_dcn_ddc.h
@@ -11,8 +11,8 @@ static inline void dcn_define_ddc_registers_common(
 		uint32_t en,
 		const struct ddc_registers *data_regs,
 		const struct ddc_registers *clk_regs,
-		const struct ddc_shift *shift,
-		const struct ddc_mask *mask)
+		const struct ddc_sh_mask *shift,
+		const struct ddc_sh_mask *mask)
 {
 	struct hw_ddc *ddc = HW_DDC_FROM_BASE(pin);
 
-- 
2.47.3

Claude review: drm/amd/display: Fix DDC register assignment type errors

[Claude Code Review Bot]

Overall Series Review

Subject: drm/amd/display: Fix DDC register assignment type errors
Author: guilhermeivo <guilhermeivob@gmail.com>
Patches: 1
Reviewed: 2026-03-25T08:17:43.938571

---

This is a single-patch fix for type errors in the `dcn_define_ddc_registers_common()` function signature. The fix is correct and straightforward. The function parameters used non-existent types (`struct ddc_shift` and `struct ddc_mask`), which should both be `struct ddc_sh_mask`. Every caller in the tree (dcn10, dcn20, dcn21, dcn30, dcn32, dcn315, dcn401, dcn42, dce60, dce80, dce110, dce120) declares their shift/mask variables as `struct ddc_sh_mask`, and `struct hw_ddc` stores them as `const struct ddc_sh_mask *`. The fix is obviously correct.

**Verdict:** Looks good. Minor nit on the commit message below.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/amd/display: Fix DDC register assignment type errors

[Claude Code Review Bot]

Patch Review

**Correctness:** The change is correct. The parameter types are changed from the non-existent `struct ddc_shift` / `struct ddc_mask` to `struct ddc_sh_mask`, which matches:
- The actual struct definition in `ddc_regs.h:130`
- The `hw_ddc` struct fields in `hw_ddc.h:34-35` (`const struct ddc_sh_mask *shifts` / `*masks`)
- All callers across every DCN/DCE generation

```c
-		const struct ddc_shift *shift,
-		const struct ddc_mask *mask)
+		const struct ddc_sh_mask *shift,
+		const struct ddc_sh_mask *mask)
```

**Nit on commit message:** The commit message says "Fix invalid type assignments in ddc_sh_mask" which is slightly misleading — the fix is in the *function parameter declarations*, not in `ddc_sh_mask` itself. Something like "Fix parameter type mismatches in dcn_define_ddc_registers_common()" would be clearer. This is minor and not a blocker.

**Note:** The `hw_factory_dcn_ddc.h` file doesn't exist in the current drm-next tree I have access to, so the patch didn't apply. This likely depends on an earlier patch that introduced this file (and the bug along with it). The fix itself is valid regardless.

**Reviewed-by worthy:** Yes, this is a simple, correct type fix.

---
Generated by Claude Code Patch Reviewer