From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Fix DDC register assignment type errors Date: Wed, 25 Mar 2026 08:17:43 +1000 Message-ID: In-Reply-To: <20260322095155.248283-1-guilhermeivob@gmail.com> References: <20260322095155.248283-1-guilhermeivob@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amd/display: Fix DDC register assignment type errors Author: guilhermeivo Patches: 1 Reviewed: 2026-03-25T08:17:43.938571 --- This is a single-patch fix for type errors in the `dcn_define_ddc_registers_common()` function signature. The fix is correct and straightforward. The function parameters used non-existent types (`struct ddc_shift` and `struct ddc_mask`), which should both be `struct ddc_sh_mask`. Every caller in the tree (dcn10, dcn20, dcn21, dcn30, dcn32, dcn315, dcn401, dcn42, dce60, dce80, dce110, dce120) declares their shift/mask variables as `struct ddc_sh_mask`, and `struct hw_ddc` stores them as `const struct ddc_sh_mask *`. The fix is obviously correct. **Verdict:** Looks good. Minor nit on the commit message below. --- Generated by Claude Code Patch Reviewer