From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: fix dead default for DRM_TTM_KUNIT_TEST
Date: Wed, 25 Mar 2026 08:10:58 +1000 [thread overview]
Message-ID: <review-overall-20260322220125.1380776-1-julianbraha@gmail.com> (raw)
In-Reply-To: <20260322220125.1380776-1-julianbraha@gmail.com>
Overall Series Review
Subject: drm: fix dead default for DRM_TTM_KUNIT_TEST
Author: Julian Braha <julianbraha@gmail.com>
Patches: 2
Reviewed: 2026-03-25T08:10:58.665235
---
This is a single-patch fix for a Kconfig ordering issue in `DRM_TTM_KUNIT_TEST`. The analysis is correct: the `default n` on line 88 shadows the `default KUNIT_ALL_TESTS` on line 94, making the latter dead code. In Kconfig, when multiple `default` statements exist, the **first** one that is visible (no unsatisfied `if` condition) wins. Since `default n` is unconditional, it always takes precedence and the `KUNIT_ALL_TESTS` default never applies.
The fix is straightforward, correct, and consistent with how other similar Kconfig entries in the same file are structured (e.g., `DRM_KUNIT_TEST` at line 60 and `DRM_SCHED_KUNIT_TEST` at line 103 both use only `default KUNIT_ALL_TESTS` without a preceding `default n`).
**Verdict: Patch looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 22:01 [PATCH] drm: fix dead default for DRM_TTM_KUNIT_TEST Julian Braha
2026-03-23 9:43 ` Christian König
2026-03-24 22:10 ` Claude review: " Claude Code Review Bot
2026-03-24 22:10 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-23 12:41 [PATCH v2] " Julian Braha
2026-03-24 21:52 ` Claude review: " Claude Code Review Bot
2026-03-24 21:52 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260322220125.1380776-1-julianbraha@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox