From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: fix dead default for DRM_TTM_KUNIT_TEST Date: Wed, 25 Mar 2026 08:10:58 +1000 Message-ID: In-Reply-To: <20260322220125.1380776-1-julianbraha@gmail.com> References: <20260322220125.1380776-1-julianbraha@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: fix dead default for DRM_TTM_KUNIT_TEST Author: Julian Braha Patches: 2 Reviewed: 2026-03-25T08:10:58.665235 --- This is a single-patch fix for a Kconfig ordering issue in `DRM_TTM_KUNIT_TEST`. The analysis is correct: the `default n` on line 88 shadows the `default KUNIT_ALL_TESTS` on line 94, making the latter dead code. In Kconfig, when multiple `default` statements exist, the **first** one that is visible (no unsatisfied `if` condition) wins. Since `default n` is unconditional, it always takes precedence and the `KUNIT_ALL_TESTS` default never applies. The fix is straightforward, correct, and consistent with how other similar Kconfig entries in the same file are structured (e.g., `DRM_KUNIT_TEST` at line 60 and `DRM_SCHED_KUNIT_TEST` at line 103 both use only `default KUNIT_ALL_TESTS` without a preceding `default n`). **Verdict: Patch looks good.** --- Generated by Claude Code Patch Reviewer