Claude review: gpu: nova-core: gsp: fix undefined behavior in command queue code

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: nova-core: gsp: fix undefined behavior in command queue code
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 5
Reviewed: 2026-03-25T08:06:34.022273

---

This is a single-patch fix for undefined behavior in the nova-core GSP command queue code. The old code called `as_slice_mut()`/`as_slice()` on the `CoherentAllocation`, which temporarily creates a Rust reference spanning the entire `GspMem` — including regions owned by the GSP that can change concurrently. Creating a `&`/`&mut` reference to memory that may be concurrently modified is UB in Rust's aliasing model, even if the returned sub-slices only cover driver-owned regions.

The fix replaces this with raw pointer arithmetic via `&raw mut`/`&raw const` and `core::slice::from_raw_parts[_mut]`, constructing slices that cover only the driver-owned portions. The approach is correct and the circular buffer logic is preserved exactly. The safety comments are thorough and reference the relevant invariants.

**Verdict: The patch looks correct and ready to merge.** One minor observation below, but nothing blocking.

---
Generated by Claude Code Patch Reviewer