From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Add HDMI 2.0 support to DW HDMI QP TX
Date: Wed, 25 Mar 2026 07:36:46 +1000 [thread overview]
Message-ID: <review-overall-20260323-dw-hdmi-qp-scramb-v4-0-1d99df84883e@collabora.com> (raw)
In-Reply-To: <20260323-dw-hdmi-qp-scramb-v4-0-1d99df84883e@collabora.com>
Overall Series Review
Subject: Add HDMI 2.0 support to DW HDMI QP TX
Author: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Patches: 5
Reviewed: 2026-03-25T07:36:46.176176
---
This is a well-structured 4-patch series adding HDMI 2.0 support (high TMDS clock ratio and scrambling) to the Synopsys DW HDMI QP TX controller, primarily targeting RK3576/RK3588. The approach is sound: introduce an atomic `detect_ctx` bridge callback (patch 1), wire it through bridge-connector (patch 2), use it in dw-hdmi-qp for SCDC management with CRTC reset on scrambling state mismatch (patch 3), and optimize HPD to per-connector events (patch 4).
The series is at v4/RESEND, has Tested-by tags from two testers, and the code is generally clean. A few issues worth addressing:
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 17:45 [PATCH RESEND v4 0/4] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-03-23 17:45 ` [PATCH RESEND v4 1/4] drm/bridge: Add ->detect_ctx hook and drm_bridge_detect_ctx() Cristian Ciocaltea
2026-03-24 21:36 ` Claude review: " Claude Code Review Bot
2026-03-23 17:45 ` [PATCH RESEND v4 2/4] drm/bridge-connector: Switch to using ->detect_ctx hook Cristian Ciocaltea
2026-03-24 21:36 ` Claude review: " Claude Code Review Bot
2026-03-23 17:45 ` [PATCH RESEND v4 3/4] drm/bridge: dw-hdmi-qp: Add high TMDS clock ratio and scrambling support Cristian Ciocaltea
2026-03-24 21:36 ` Claude review: " Claude Code Review Bot
2026-03-23 17:45 ` [PATCH RESEND v4 4/4] drm/rockchip: dw_hdmi_qp: Do not send HPD events for all connectors Cristian Ciocaltea
2026-03-24 21:36 ` Claude review: " Claude Code Review Bot
2026-03-24 21:36 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-03 1:38 [PATCH v4 0/4] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-03-03 2:42 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260323-dw-hdmi-qp-scramb-v4-0-1d99df84883e@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox