From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add HDMI 2.0 support to DW HDMI QP TX Date: Wed, 25 Mar 2026 07:36:46 +1000 Message-ID: In-Reply-To: <20260323-dw-hdmi-qp-scramb-v4-0-1d99df84883e@collabora.com> References: <20260323-dw-hdmi-qp-scramb-v4-0-1d99df84883e@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add HDMI 2.0 support to DW HDMI QP TX Author: Cristian Ciocaltea Patches: 5 Reviewed: 2026-03-25T07:36:46.176176 --- This is a well-structured 4-patch series adding HDMI 2.0 support (high TMDS clock ratio and scrambling) to the Synopsys DW HDMI QP TX controller, primarily targeting RK3576/RK3588. The approach is sound: introduce an atomic `detect_ctx` bridge callback (patch 1), wire it through bridge-connector (patch 2), use it in dw-hdmi-qp for SCDC management with CRTC reset on scrambling state mismatch (patch 3), and optimize HPD to per-connector events (patch 4). The series is at v4/RESEND, has Tested-by tags from two testers, and the code is generally clean. A few issues worth addressing: --- Generated by Claude Code Patch Reviewer