From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: sharp-ls043t1le01: make use of prepare_prev_first Date: Wed, 25 Mar 2026 08:09:53 +1000 Message-ID: In-Reply-To: <20260323-panel-fix-v1-1-9f12b09161e8@oss.qualcomm.com> References: <20260323-panel-fix-v1-1-9f12b09161e8@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/panel: sharp-ls043t1le01: make use of prepare_prev_first Author: Dmitry Baryshkov Patches: 2 Reviewed: 2026-03-25T08:09:53.961252 --- This is a straightforward, correct, single-patch fix. The Sharp LS043T1LE01 is a DSI panel whose `prepare()` callback sends DSI commands (exit sleep mode, set pixel format, set display on via `mipi_dsi_dcs_*` calls). After commit 9e15123eca79 stopped unconditionally powering up DSI hosts at modeset, the DSI link may not be ready when the panel's `prepare()` runs, causing those commands to fail. Setting `prepare_prev_first = true` ensures the DSI host is initialized before the panel's `prepare()` is called, which is the standard fix for this class of problem. The patch is well-motivated, follows established patterns used by many other DSI panel drivers, and the placement after `drm_panel_init()` is correct and consistent with other drivers. **Recommendation: Accept as-is.** --- Generated by Claude Code Patch Reviewer