* [PATCH] drm/accel: remove unnecessary cast in accel_name_info()
@ 2026-03-23 2:29 Onat Baker
2026-03-24 22:08 ` Claude review: " Claude Code Review Bot
2026-03-24 22:08 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Onat Baker @ 2026-03-23 2:29 UTC (permalink / raw)
To: Oded Gabbay; +Cc: dri-devel, linux-kernel, Onat Baker
m->private is a void pointer and does not need to be cast to
struct drm_info_node * in C. Remove the unnecessary cast.
Signed-off-by: Onat Baker <onatbaker@gmail.com>
---
drivers/accel/drm_accel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
index ca3357acd127..8cb359df13cf 100644
--- a/drivers/accel/drm_accel.c
+++ b/drivers/accel/drm_accel.c
@@ -46,7 +46,7 @@ static void accel_sysfs_destroy(void)
static int accel_name_info(struct seq_file *m, void *data)
{
- struct drm_info_node *node = (struct drm_info_node *) m->private;
+ struct drm_info_node *node = m->private;
struct drm_minor *minor = node->minor;
struct drm_device *dev = minor->dev;
struct drm_master *master;
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Claude review: drm/accel: remove unnecessary cast in accel_name_info()
2026-03-23 2:29 [PATCH] drm/accel: remove unnecessary cast in accel_name_info() Onat Baker
@ 2026-03-24 22:08 ` Claude Code Review Bot
2026-03-24 22:08 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-24 22:08 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Status: Correct, trivially so.**
The change:
```c
// Before:
struct drm_info_node *node = (struct drm_info_node *) m->private;
// After:
struct drm_info_node *node = m->private;
```
`m->private` is `void *` (from `struct seq_file`), so the cast to `struct drm_info_node *` is unnecessary in C. The patch is correct.
**Minor observations:**
- The commit message is clear and accurately describes the change.
- `Signed-off-by` is present.
- No functional change, no risk of regression.
- This same pattern (removing void* casts) exists across many kernel files; a series cleaning up multiple instances would carry more weight than a single-line change.
**No issues found.**
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: drm/accel: remove unnecessary cast in accel_name_info()
2026-03-23 2:29 [PATCH] drm/accel: remove unnecessary cast in accel_name_info() Onat Baker
2026-03-24 22:08 ` Claude review: " Claude Code Review Bot
@ 2026-03-24 22:08 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-24 22:08 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm/accel: remove unnecessary cast in accel_name_info()
Author: Onat Baker <onatbaker@gmail.com>
Patches: 1
Reviewed: 2026-03-25T08:08:40.499099
---
This is a trivial single-patch cleanup that removes an unnecessary explicit cast from `void *` to `struct drm_info_node *`. In C, `void *` is implicitly convertible to any pointer type, so the cast is indeed superfluous. The change is correct and harmless.
That said, this is an extremely minor cosmetic cleanup with no functional impact. It's the kind of patch that is technically correct but offers minimal value — it touches a single line to remove a cast that causes no warnings and no bugs.
**Verdict: Low-value but correct cleanup.**
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-24 22:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-23 2:29 [PATCH] drm/accel: remove unnecessary cast in accel_name_info() Onat Baker
2026-03-24 22:08 ` Claude review: " Claude Code Review Bot
2026-03-24 22:08 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox