public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: Fix potential out-of-bounds access in 'amdgpu_discovery_reg_base_init()'
Date: Wed, 25 Mar 2026 08:02:38 +1000	[thread overview]
Message-ID: <review-overall-20260323071052.4068410-1-1468888505@139.com> (raw)
In-Reply-To: <20260323071052.4068410-1-1468888505@139.com>

Overall Series Review

Subject: drm/amdgpu: Fix potential out-of-bounds access in 'amdgpu_discovery_reg_base_init()'
Author: Li hongliang <1468888505@139.com>
Patches: 6
Reviewed: 2026-03-25T08:02:38.488122

---

This is a single-patch stable backport (targeting 6.1.y) of upstream commit `cdb637d339572398821204a1142d8d615668f1e9`, which fixes a potential out-of-bounds array access in `amdgpu_discovery_reg_base_init()`. The original fix was authored by Srinivasan Shanmugam and reviewed by Alex Deucher. The backport submitter (Li hongliang) notes a minor conflict was resolved.

The core idea is correct: the bounds check on `adev->vcn.num_vcn_inst` must happen **before** using it as an array index into `vcn_config[]`, not after.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-24 22:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  7:10 [PATCH 6.1.y] drm/amdgpu: Fix potential out-of-bounds access in 'amdgpu_discovery_reg_base_init()' Li hongliang
2026-03-23  9:51 ` Christian König
2026-03-23 10:32   ` Greg KH
2026-03-23 12:28     ` Christian König
2026-03-23 12:37       ` Greg KH
2026-03-24  0:52         ` Re:Re: [PATCH 6.1.y] drm/amdgpu: Fix potential out-of-bounds access in'amdgpu_discovery_reg_base_init()' 18801328227
2026-03-24 22:02 ` Claude review: drm/amdgpu: Fix potential out-of-bounds access in 'amdgpu_discovery_reg_base_init()' Claude Code Review Bot
2026-03-24 22:02 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260323071052.4068410-1-1468888505@139.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox