* Re: [PATCH] drm/panthor: correct firmware related messages
2026-03-23 8:11 [PATCH] drm/panthor: correct firmware related messages Christian Hewitt
@ 2026-03-23 8:22 ` Boris Brezillon
2026-03-23 11:18 ` Liviu Dudau
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2026-03-23 8:22 UTC (permalink / raw)
To: Christian Hewitt
Cc: Steven Price, Liviu Dudau, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
On Mon, 23 Mar 2026 08:11:32 +0000
Christian Hewitt <christianshewitt@gmail.com> wrote:
> Some English language corrections to firmware messages. No
> functional changes.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index a64ec8756bed..349bb6b0e7bf 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -580,7 +580,7 @@ static int panthor_fw_load_section_entry(struct panthor_device *ptdev,
>
> if (hdr.flags & CSF_FW_BINARY_IFACE_ENTRY_PROT) {
> drm_warn(&ptdev->base,
> - "Firmware protected mode entry not be supported, ignoring");
> + "Firmware protected mode entry is not supported, ignoring");
> return 0;
> }
>
> @@ -749,7 +749,7 @@ static int panthor_fw_load_entry(struct panthor_device *ptdev,
>
> if ((iter->offset % sizeof(u32)) ||
> (CSF_FW_BINARY_ENTRY_SIZE(ehdr) % sizeof(u32))) {
> - drm_err(&ptdev->base, "Firmware entry isn't 32 bit aligned, offset=0x%x size=0x%x\n",
> + drm_err(&ptdev->base, "Firmware entry is not 32-bit aligned, offset=0x%x size=0x%x\n",
> (u32)(iter->offset - sizeof(u32)), CSF_FW_BINARY_ENTRY_SIZE(ehdr));
> return -EINVAL;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/panthor: correct firmware related messages
2026-03-23 8:11 [PATCH] drm/panthor: correct firmware related messages Christian Hewitt
2026-03-23 8:22 ` Boris Brezillon
@ 2026-03-23 11:18 ` Liviu Dudau
2026-03-24 16:06 ` Liviu Dudau
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Liviu Dudau @ 2026-03-23 11:18 UTC (permalink / raw)
To: Christian Hewitt
Cc: Boris Brezillon, Steven Price, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
On Mon, Mar 23, 2026 at 08:11:32AM +0000, Christian Hewitt wrote:
> Some English language corrections to firmware messages. No
> functional changes.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index a64ec8756bed..349bb6b0e7bf 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -580,7 +580,7 @@ static int panthor_fw_load_section_entry(struct panthor_device *ptdev,
>
> if (hdr.flags & CSF_FW_BINARY_IFACE_ENTRY_PROT) {
> drm_warn(&ptdev->base,
> - "Firmware protected mode entry not be supported, ignoring");
> + "Firmware protected mode entry is not supported, ignoring");
> return 0;
> }
>
> @@ -749,7 +749,7 @@ static int panthor_fw_load_entry(struct panthor_device *ptdev,
>
> if ((iter->offset % sizeof(u32)) ||
> (CSF_FW_BINARY_ENTRY_SIZE(ehdr) % sizeof(u32))) {
> - drm_err(&ptdev->base, "Firmware entry isn't 32 bit aligned, offset=0x%x size=0x%x\n",
> + drm_err(&ptdev->base, "Firmware entry is not 32-bit aligned, offset=0x%x size=0x%x\n",
> (u32)(iter->offset - sizeof(u32)), CSF_FW_BINARY_ENTRY_SIZE(ehdr));
> return -EINVAL;
> }
> --
> 2.43.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/panthor: correct firmware related messages
2026-03-23 8:11 [PATCH] drm/panthor: correct firmware related messages Christian Hewitt
2026-03-23 8:22 ` Boris Brezillon
2026-03-23 11:18 ` Liviu Dudau
@ 2026-03-24 16:06 ` Liviu Dudau
2026-03-24 22:01 ` Claude review: " Claude Code Review Bot
2026-03-24 22:01 ` Claude Code Review Bot
4 siblings, 0 replies; 6+ messages in thread
From: Liviu Dudau @ 2026-03-24 16:06 UTC (permalink / raw)
To: Christian Hewitt
Cc: Boris Brezillon, Steven Price, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
On Mon, Mar 23, 2026 at 08:11:32AM +0000, Christian Hewitt wrote:
> Some English language corrections to firmware messages. No
> functional changes.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Pushed to drm-misc-next.
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index a64ec8756bed..349bb6b0e7bf 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -580,7 +580,7 @@ static int panthor_fw_load_section_entry(struct panthor_device *ptdev,
>
> if (hdr.flags & CSF_FW_BINARY_IFACE_ENTRY_PROT) {
> drm_warn(&ptdev->base,
> - "Firmware protected mode entry not be supported, ignoring");
> + "Firmware protected mode entry is not supported, ignoring");
> return 0;
> }
>
> @@ -749,7 +749,7 @@ static int panthor_fw_load_entry(struct panthor_device *ptdev,
>
> if ((iter->offset % sizeof(u32)) ||
> (CSF_FW_BINARY_ENTRY_SIZE(ehdr) % sizeof(u32))) {
> - drm_err(&ptdev->base, "Firmware entry isn't 32 bit aligned, offset=0x%x size=0x%x\n",
> + drm_err(&ptdev->base, "Firmware entry is not 32-bit aligned, offset=0x%x size=0x%x\n",
> (u32)(iter->offset - sizeof(u32)), CSF_FW_BINARY_ENTRY_SIZE(ehdr));
> return -EINVAL;
> }
> --
> 2.43.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 6+ messages in thread* Claude review: drm/panthor: correct firmware related messages
2026-03-23 8:11 [PATCH] drm/panthor: correct firmware related messages Christian Hewitt
` (2 preceding siblings ...)
2026-03-24 16:06 ` Liviu Dudau
@ 2026-03-24 22:01 ` Claude Code Review Bot
2026-03-24 22:01 ` Claude Code Review Bot
4 siblings, 0 replies; 6+ messages in thread
From: Claude Code Review Bot @ 2026-03-24 22:01 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm/panthor: correct firmware related messages
Author: Christian Hewitt <christianshewitt@gmail.com>
Patches: 4
Reviewed: 2026-03-25T08:01:15.664973
---
This is a single trivial patch that fixes two grammatical/typo issues in firmware-related log messages in the panthor DRM driver. No functional changes. The fixes are correct and reasonable.
**Verdict: Looks good.** No concerns.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 6+ messages in thread* Claude review: drm/panthor: correct firmware related messages
2026-03-23 8:11 [PATCH] drm/panthor: correct firmware related messages Christian Hewitt
` (3 preceding siblings ...)
2026-03-24 22:01 ` Claude review: " Claude Code Review Bot
@ 2026-03-24 22:01 ` Claude Code Review Bot
4 siblings, 0 replies; 6+ messages in thread
From: Claude Code Review Bot @ 2026-03-24 22:01 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Fix 1** (line 110): Changes `"Firmware protected mode entry not be supported, ignoring"` to `"Firmware protected mode entry is not supported, ignoring"` — clearly a grammar fix for a broken sentence ("not be supported" → "is not supported"). Correct.
**Fix 2** (line 120): Changes `"Firmware entry isn't 32 bit aligned"` to `"Firmware entry is not 32-bit aligned"` — two changes here:
- `isn't` → `is not`: stylistic preference for formal language in kernel messages. Reasonable, though the kernel has no strict rule against contractions.
- `32 bit` → `32-bit`: correct hyphenation when used as a compound adjective. This is the more substantive language fix.
Both changes confirmed against the current drm-next tree. The patch is straightforward, low-risk, and improves message clarity.
**Reviewed-by: appropriate** — no issues found.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 6+ messages in thread