From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: fix dead default for DRM_TTM_KUNIT_TEST
Date: Wed, 25 Mar 2026 07:52:18 +1000 [thread overview]
Message-ID: <review-overall-20260323124118.1414913-1-julianbraha@gmail.com> (raw)
In-Reply-To: <20260323124118.1414913-1-julianbraha@gmail.com>
Overall Series Review
Subject: drm: fix dead default for DRM_TTM_KUNIT_TEST
Author: Julian Braha <julianbraha@gmail.com>
Patches: 2
Reviewed: 2026-03-25T07:52:18.917094
---
This is a single, straightforward Kconfig fix. The analysis is correct: in Kconfig, when multiple `default` statements exist, the **first** one encountered takes precedence. Here, `default n` on line 88 comes before `default KUNIT_ALL_TESTS` on line 94, so the latter is dead code — `KUNIT_ALL_TESTS` can never actually influence the default value of `DRM_TTM_KUNIT_TEST`.
The fix (removing `default n`) is the right approach. Once removed, `default KUNIT_ALL_TESTS` becomes effective, and when `KUNIT_ALL_TESTS` is not set, Kconfig's implicit default for tristate is `n` anyway, so behavior is preserved for users who don't set `KUNIT_ALL_TESTS`.
**Verdict: Patch looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 12:41 [PATCH v2] drm: fix dead default for DRM_TTM_KUNIT_TEST Julian Braha
2026-03-24 16:04 ` Christian König
2026-03-24 21:52 ` Claude Code Review Bot [this message]
2026-03-24 21:52 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-22 22:01 [PATCH] " Julian Braha
2026-03-24 22:10 ` Claude review: " Claude Code Review Bot
2026-03-24 22:10 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260323124118.1414913-1-julianbraha@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox