From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: fix dead default for DRM_TTM_KUNIT_TEST Date: Wed, 25 Mar 2026 07:52:18 +1000 Message-ID: In-Reply-To: <20260323124118.1414913-1-julianbraha@gmail.com> References: <20260323124118.1414913-1-julianbraha@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: fix dead default for DRM_TTM_KUNIT_TEST Author: Julian Braha Patches: 2 Reviewed: 2026-03-25T07:52:18.917094 --- This is a single, straightforward Kconfig fix. The analysis is correct: in = Kconfig, when multiple `default` statements exist, the **first** one encoun= tered takes precedence. Here, `default n` on line 88 comes before `default = KUNIT_ALL_TESTS` on line 94, so the latter is dead code =E2=80=94 `KUNIT_AL= L_TESTS` can never actually influence the default value of `DRM_TTM_KUNIT_T= EST`. The fix (removing `default n`) is the right approach. Once removed, `defaul= t KUNIT_ALL_TESTS` becomes effective, and when `KUNIT_ALL_TESTS` is not set= , Kconfig's implicit default for tristate is `n` anyway, so behavior is pre= served for users who don't set `KUNIT_ALL_TESTS`. **Verdict: Patch looks good.** --- Generated by Claude Code Patch Reviewer