From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: track colorop changes of a given plane Date: Wed, 25 Mar 2026 07:51:14 +1000 Message-ID: In-Reply-To: <20260323131942.494217-1-mwen@igalia.com> References: <20260323131942.494217-1-mwen@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: track colorop changes of a given plane Author: Melissa Wen Patches: 3 Reviewed: 2026-03-25T07:51:14.429216 --- This is a clean, well-structured 2-patch series that adds change tracking for colorop properties in the DRM atomic API's color pipeline. The approach mirrors the existing `color_mgmt_changed` pattern already used for CRTC color management, which is good for consistency. The series solves a real bug (gamescope night mode shaper/3D LUT updates not taking effect) with minimal, focused changes. The overall design is sound: patch 1 adds the core infrastructure in the DRM atomic helpers, and patch 2 consumes it in the amdgpu driver. The change-detection logic (only marking `color_mgmt_changed` when values actually differ) avoids unnecessary driver work on redundant sets, which is a nice touch. **Series verdict: Looks good.** A few minor observations below, but nothing blocking. --- --- Generated by Claude Code Patch Reviewer